Skip to content

docs(README): document suggestion limitations #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DanielWTQ
Copy link

Spent a while debugging only to find out that this was a part of the code of the action rather than something wrong on our end.

Spent a while debugging only to find out that this was a part of the code of
the action rather than something wrong on our end.
@DanielWTQ
Copy link
Author

Limitation comes from

suggest-changes/index.js

Lines 24 to 34 in e512b94

const pullRequestFiles = (
await octokit.pulls.listFiles({ owner, repo, pull_number })
).data.map((file) => file.filename)
// Get the diff between the head branch and the base branch (limit to the files in the pull request)
const diff = await getExecOutput(
'git',
['diff', '--unified=1', '--', ...pullRequestFiles],
{ silent: true }
)

@parkerbxyz
Copy link
Owner

Thanks for opening this pull request and for your patience!

This is actually a GitHub limitation, not necessarily a limitation of this action: https://github.com/orgs/community/discussions/9099.

I'm open to including a note about this limitation in the README. I'd probably like to include a note that review comments can only be left on/around edited lines: https://github.com/orgs/community/discussions/4452.

@parkerbxyz parkerbxyz changed the title README: document file limitation docs(README): document suggestion limitations Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants