-
-
Notifications
You must be signed in to change notification settings - Fork 600
fix: TypeScript type resolution errors for parse/node and parse/react-native subpaths
#2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TypeScript type resolution errors for parse/node and parse/react-native subpaths
#2849
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughAdded TypeScript type-resolution mappings and Node/React Native subpath exports to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json
🔇 Additional comments (1)
package.json (1)
30-35: LGTM! Correct approach for TypeScript compatibility.The
typesVersionsfield correctly provides backward compatibility for TypeScript versions < 4.7 andmoduleResolution: "node". The mappings fornodeandreact-nativesubpaths align perfectly with the issue requirements.
|
@mtrezza Can you please check my pull request |
|
@coderabbitai does this PR contain a breaking change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #2849 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 64 64
Lines 6222 6222
Branches 1473 1473
=======================================
Hits 6215 6215
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tip For best results, initiate chat on the files or code changes. @mtrezza: This PR has the potential to be a breaking change, though mitigations are in place. Here's the analysis: Why it could be breaking:
Mitigations in place:
Non-breaking aspect:
Recommendation:To verify this isn't breaking, check if:
If this package follows semantic versioning and there's any doubt, this should be released as a major version or thoroughly tested in a pre-release to avoid breaking existing users. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 9082 @mtrezza, this PR has a low risk of being a breaking change, but there is a small possibility in edge cases. Here's my analysis: AnalysisNon-Breaking Aspects ✅
Potential Breaking Aspect
|
|
@coderabbitai propose a commit message for non-breaking PR with |
|
Tip For best results, initiate chat on the files or code changes. @mtrezza: Here's a suggested commit message for this non-breaking fix: Alternative shorter version: Choose whichever level of detail you prefer. The first provides more context about the solution and compatibility, while the second is more concise. |
parse/node and parse/react-native subpaths
## [8.0.1-alpha.1](8.0.0...8.0.1-alpha.1) (2026-01-05) ### Bug Fixes * TypeScript type resolution errors for `parse/node` and `parse/react-native` subpaths ([#2849](#2849)) ([de684e5](de684e5))
|
🎉 This change has been released in version 8.0.1-alpha.1 |
Pull Request
Issue
Closes: #2848
Approach
Adds
typesVersionsandexportsfields topackage.jsonto expose type mappings for subpath imports (parse/node,parse/react-native).typesVersions: Provides backward compatibility for older TypeScript versions andmoduleResolution: "node"exports: Modern approach for TypeScript 4.7+ withmoduleResolution: "node16"or"bundler"Tasks
npm run test:typespasses)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.