Skip to content

Conversation

rchowell
Copy link
Contributor

@rchowell rchowell commented Nov 25, 2024

Description

This PR adds a source and sink API to the SPI package which will become the backing interfaces for various PartiQL encoding schemes (firstly Ion). These APIs are just like the reader/writer APIs from IonJava, but are intended to be extended to get values into a PartiQL system. The primary/default application here will be to encode PartiQL data in typed Ion.

See #1654

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchowell rchowell requested a review from johnedquinn November 25, 2024 21:14
Comment on lines +43 to +45
@NotNull
BigDecimal readDecimal();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing

@NotNull
BigDecimal readNumeric();

Comment on lines +29 to +31
void readNull();

void readMissing();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely not necessary as these have no effect

/**
* Positions the source to the next value, return its type.
*/
PType next();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotate as nullable

Copy link

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-FA2CB2C) +/-
% Passing 89.67% 88.09% -1.58% ⭕
Passing 5287 5194 -93 ⭕
Failing 609 421 -188 ✅
Ignored 0 281 281 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: fa2cb2c
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2463
  • Failing in both: 21
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 183
  • PASSING in BASE but now IGNORED in TARGET: 108
  • FAILING in BASE but now PASSING in TARGET: 176
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

176 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-FA2CB2C). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ❌

BASE (EVAL-6A4B3E2) TARGET (EVAL-FA2CB2C) +/-
% Passing 88.11% 88.09% -0.02% ⭕
Passing 5195 5194 -1 ⭕
Failing 420 421 1 ⭕
Ignored 281 281 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 6a4b3e2
  • Base Engine: EVAL
  • Target Commit: fa2cb2c
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 5194
  • Failing in both: 420
  • Ignored in both: 281
  • PASSING in BASE but now FAILING in TARGET: 1
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The following 1 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. MYSQL_SELECT_29, compileOption: STRICT

@rchowell rchowell marked this pull request as draft November 25, 2024 22:19
@rchowell
Copy link
Contributor Author

waiting until datetime PR #1657 is in and rebase

@rchowell
Copy link
Contributor Author

Replaced by #1687

@rchowell rchowell closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant