Removes Datum#getBigInteger() and deprecation notices on Datum
#1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedquinn
force-pushed
the
main-remove-big-integer
branch
3 times, most recently
from
801bcbb to
2d59c97
Compare
Updates BitwiseAndTest to only use integers Removes deprecated notices for Datum#getBytes and Datum#getByte Adds InvalidOperationException to Datum Updates signatures
johnedquinn
force-pushed
the
main-remove-big-integer
branch
from
2d59c97 to
7fa1b11
Compare
alancai98
previously approved these changes
Jan 10, 2025
| PType.bool() | ||
| ) | ||
|
|
||
| val allIntPType = setOf(PType.tinyint(), PType.smallint(), PType.integer(), PType.bigint(), PType.numeric(38, 0)) |
There was a problem hiding this comment.
since PType.numeric is removed here, should we add it to the below variable, allNumberPType
alancai98
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Datum#getBigInteger()and deprecation notices on DatumLicense Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.