Audits eval package #1709
Merged
Audits eval package #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
=========================================
Coverage 80.03% 80.03%
Complexity 47 47
=========================================
Files 19 19
Lines 506 506
Branches 23 23
=========================================
Hits 405 405
Misses 88 88
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alancai98
approved these changes
Jan 13, 2025
| */ | ||
| public class Row { | ||
|
|
||
| private final Datum[] values; |
There was a problem hiding this comment.
nit: perhaps could still be helpful to have a method to get all the values?
johnedquinn
added a commit
to johnedquinn/partiql-lang-jvm
that referenced
this pull request
Jan 15, 2025
This reverts commit a7b772e.
johnedquinn
added a commit
that referenced
this pull request
Jan 15, 2025
* Fixes 6 arithmetic tests * Fixes 39 conformance tests related to typing of functions * Makes the MOD funtion public, as dictated by SQL:1999 * Revert "Audits eval package (#1709)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getValues()onRow.License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.