feat: EXCLUDE transpilation to Trino #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
force-pushed
the
feat-spark-exclude
branch
from
7bf2ade to
a133154
Compare
alancai98
force-pushed
the
feat-trino-exclude
branch
from
518b35a to
5c26e34
Compare
alancai98
force-pushed
the
feat-spark-exclude
branch
from
0af3a6f to
133be53
Compare
alancai98
force-pushed
the
feat-trino-exclude
branch
from
5c26e34 to
76751bf
Compare
alancai98
commented
Jun 17, 2025
| @@ -0,0 +1,73 @@ | |||
| This document goes over one of the more complicated rewrites for PartiQL's `EXCLUDE` to Trino. | |||
There was a problem hiding this comment.
self-review: transpilation of EXCLUDE to Trino is mostly the same as what we did for SparkSQL. Major difference is how to re-create the structs with excluded fields, which requires using the CAST(ROW(...) AS ROW()) syntax.
alancai98
changed the title
alancai98
force-pushed
the
feat-spark-exclude
branch
from
133be53 to
0caef35
Compare
alancai98
force-pushed
the
feat-trino-exclude
branch
from
76751bf to
e1e4815
Compare
alancai98
force-pushed
the
feat-trino-exclude
branch
from
e1e4815 to
a330d17
Compare
jpschorr
approved these changes
Jun 25, 2025
| @@ -0,0 +1,73 @@ | |||
| This document goes over one of the more complicated rewrites for PartiQL's `EXCLUDE` to Trino. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.