Fixes miscellaneous test cases #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpschorr
reviewed
Aug 8, 2024
Comment on lines
26
to
+37
| statement:"select x.someColumn from <<{'someColumn': MISSING}>> AS x", | ||
| assert:{ | ||
| evalMode:[EvalModeCoerce, EvalModeError], | ||
| result:EvaluationSuccess, | ||
| output:$bag::[{}] | ||
| } | ||
| assert: [ | ||
| { | ||
| evalMode: EvalModeCoerce, | ||
| result: EvaluationSuccess, | ||
| output: $bag::[{}] | ||
| }, | ||
| { | ||
| evalMode: EvalModeError, | ||
| result: EvaluationFail | ||
| } | ||
| ] |
There was a problem hiding this comment.
- This is equivalent to
select x.someColumn from <<{}>> AS x, which should fail in type checking as per spec secion4.1
Comment on lines
41
to
47
| statement:"select * from <<{'someColumn': MISSING}>>", | ||
| assert:{ | ||
| evalMode:[EvalModeCoerce, EvalModeError], | ||
| result:EvaluationSuccess, | ||
| output:$bag::[ | ||
| { | ||
| _1:{} | ||
| } | ||
| ] | ||
| output:$bag::[ { } ] | ||
| } | ||
| } |
There was a problem hiding this comment.
- This is equivalent to
select * from <<{}>>
Comment on lines
+55
to
+56
| evalMode: EvalModeError, | ||
| result: EvaluationFail |
There was a problem hiding this comment.
- Fails because it attempts to create tuples like
{0: 'Kumo'}and0is an invalid type for the key of a struct.
jpschorr
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other small fixes that are relatively straightforward.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.