(PC-38439)[PRO] feat: add highlight requests to offers list #20033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchaffal-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
rchaffal-pass
temporarily deployed
to
pullrequest
GitHub Actions
Inactive
abouabdallaoui-pass
approved these changes
Oct 30, 2025
ogeber-pass
approved these changes
Oct 30, 2025
...OffersContainer/components/IndividualOfferColumns/components/OfferNameCell/OfferNameCell.tsx
Show resolved
Hide resolved
tpommellet-pass
approved these changes
Oct 31, 2025
| <Thumb url={offer.thumbUrl} /> | ||
| </div> | ||
| <div> | ||
| {offer.isShowcase && <Tag label="Offre vitrine" />} |
There was a problem hiding this comment.
Pourquoi a-t-on supprimé le tag
There was a problem hiding this comment.
parce qu'on a dédupliquer ce composantr qui servait pour les offres individuelles et collectives et que c'est une notion de collectif
| ).joinedload(models.Offer.headlineOffers) | ||
| ) | ||
| .options( | ||
| sa_orm.joinedload(models.Offer.highlight_requests).joinedload(highlights_models.HighlightRequest.highlight), |
There was a problem hiding this comment.
Question pour @ogeber-pass : est-ce qu'il y a un risque de détériorer les performances ici ou pas vraiment ?
There was a problem hiding this comment.
en effet, tu peux faire un explain analyze et vérifier que tu n'as pas introduit de seq scan
There was a problem hiding this comment.
J'ai ajoute dans le ticket un commentaire avec l'analyse AVANT/APRES : https://passculture.atlassian.net/browse/PC-38268?focusedCommentId=71394
A regarder lundi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Related Ticket or 🔧 Changes Made
Ticket Jira
ticket front + back