-
Notifications
You must be signed in to change notification settings - Fork 45
Pc 38501 share link and slide panel component #20039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Pc 38501 share link and slide panel component #20039
Conversation
0ae83fa to
ebf57e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je crois qu'il y a eu un oubli dans le ticket, il ne faut pas permettre de partager une offre si elle est brouillon, en instruction, non conforme, archivée, en pause, terminée (cf maquette) mais sinon c'est top !
pro/src/components/ShareLink/ShareLinkButton/ShareLinkButton.module.scss
Outdated
Show resolved
Hide resolved
pro/src/components/ShareLink/ShareLinkDrawer/ShareLinkDrawer.tsx
Outdated
Show resolved
Hide resolved
...rLayout/CollectiveEditionOfferNavigation/__specs__/CollectiveEditionOfferNavigation.spec.tsx
Show resolved
Hide resolved
|
|
||
| export const ShareLinkDrawer = () => { | ||
| const [isOpenDialog, setIsOpenDialog] = useState(false) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce composant ne sera utilisé que dans le cadre des offres collectives, ce n'est pas un composant générique ou partagé. Ne pas le mettre dans shareLink à la racine des composants.
| React.ComponentProps<typeof Button> | ||
| >((props, ref) => { | ||
| return ( | ||
| <div className={styles.shareLinkContainer}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce composant doit être générique est se trouver dans UI-KIT
ebf57e4 to
fcfada2
Compare
🎯 Related Ticket or 🔧 Changes Made
Ticket Jira
Dev sous FF : WIP_ENABLE_COLLECTIVE_OFFER_TEMPLATE_SHARE_LINK
Créer le composant de bouton pour partager (avec le tag Nouveau)
Créer le composant du drawer qui utilise le bouton pour partager
Utilisation du composant Drawer dans les endroits où il le fallait (aperçu, récap, liste des actions dans la liste des offres) seulement pour les offres vitrines