Skip to content

build: change codegen to move generated files to src/generated #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 7, 2025

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 requested a review from a team January 7, 2025 22:22
@ctran88 ctran88 force-pushed the PSG-5686-update-codegen-dir branch from 76e479b to ff0e895 Compare January 7, 2025 22:34
@ctran88 ctran88 force-pushed the PSG-5686-change-dir-structure branch from c23b809 to 5afa6ce Compare January 9, 2025 01:07
@ctran88 ctran88 force-pushed the PSG-5686-update-codegen-dir branch from ff0e895 to 5c81525 Compare January 9, 2025 01:09
Copy link
Contributor

@vanessa-passage vanessa-passage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Same curiosities as the other. I'd love to learn more about this SDK and probs you may have faced that prompted these changes. This is just for my own knowledge.

@ctran88 ctran88 force-pushed the PSG-5686-change-dir-structure branch from 5afa6ce to e54af75 Compare January 10, 2025 19:09
Base automatically changed from PSG-5686-change-dir-structure to main January 10, 2025 19:10
@ctran88
Copy link
Contributor Author

ctran88 commented Jan 10, 2025

Changes look good.

Same curiosities as the other. I'd love to learn more about this SDK and probs you may have faced that prompted these changes. This is just for my own knowledge.

this was really just structural. nothing functionally changed or caused the need for this change other than conforming to a common directory structure. in presenting a library, there's no real distinction to be made between "custom" and "generated" code other than for our own sake, so i thought it'd be better to organize it like a typical php project with a src and tests folder at the root and flattening out the generated code structure a bit as well

@ctran88 ctran88 force-pushed the PSG-5686-update-codegen-dir branch from 5c81525 to a2f0afb Compare January 10, 2025 19:16
@ctran88 ctran88 merged commit b041c47 into main Jan 10, 2025
4 checks passed
@ctran88 ctran88 deleted the PSG-5686-update-codegen-dir branch January 10, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants