Skip to content

feat: remove auth origin comparison from jwt audience validation #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 23, 2024

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the remove-auth-origin-aud-validation branch from b24f889 to 154caca Compare December 23, 2024 20:35
@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from aed30fa to 4c206d6 Compare December 23, 2024 20:50
@ctran88 ctran88 force-pushed the remove-auth-origin-aud-validation branch from 154caca to 58b1bad Compare December 23, 2024 20:55
@ctran88 ctran88 requested a review from a team December 23, 2024 20:55
@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from 4c206d6 to 23a00b2 Compare January 2, 2025 19:53
@ctran88 ctran88 force-pushed the remove-auth-origin-aud-validation branch from 58b1bad to 44a2211 Compare January 2, 2025 19:59
Copy link
Contributor

@bertrmz bertrmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, this can be tested locally with backend-sdk-tests as:

BRANCH=remove-auth-origin-aud-validation task python:test-release -- validate-jwt

@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from 23a00b2 to 06a1b73 Compare January 3, 2025 17:19
Base automatically changed from PSG-5214-remove-deprecated-methods to main January 3, 2025 17:22
@ctran88 ctran88 force-pushed the remove-auth-origin-aud-validation branch from 44a2211 to 8915d15 Compare January 3, 2025 17:30
Copy link

sonarqubecloud bot commented Jan 3, 2025

@ctran88 ctran88 merged commit 52b6859 into main Jan 3, 2025
6 checks passed
@ctran88 ctran88 deleted the remove-auth-origin-aud-validation branch January 3, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants