Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use coerceToArrayBuffer to post-process assertion options in Demo js #467

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

dradovic
Copy link
Contributor

Just did the todos from the comments.

@dradovic
Copy link
Contributor Author

@dotnet-policy-service agree

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.93%. Comparing base (3ab071f) to head (6db2dae).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         100      100           
  Lines        2627     2627           
  Branches      441      441           
=======================================
  Hits         2021     2021           
  Misses        498      498           
  Partials      108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dradovic
Copy link
Contributor Author

Note that there's a subtle change here: by using coerceToArrayBuffer the bytes are copied in a for-loop instead of using Uint8Array.from.

@abergs
Copy link
Collaborator

abergs commented Nov 5, 2024

Long time coming but let's merge this now :)

@abergs
Copy link
Collaborator

abergs commented Nov 5, 2024

Thanks @dradovic!

@abergs abergs merged commit ce6374c into passwordless-lib:master Nov 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants