Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure Ubuntu-based base images work as expected; change default to vanilla Debian #115

Merged
merged 12 commits into from
Apr 7, 2025

Conversation

dionhaefner
Copy link
Contributor

@dionhaefner dionhaefner commented Apr 2, 2025

Relevant issue or PR

Fixes #112

Description of changes

Testing done

License

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I sign the Developer Certificate of Origin below by adding my name and email address to the Signed-off-by line.
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Dion Häfner [email protected]

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.47%. Comparing base (a61f361) to head (9be6db0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   76.40%   76.47%   +0.07%     
==========================================
  Files          26       26              
  Lines        2606     2606              
  Branches      390      390              
==========================================
+ Hits         1991     1993       +2     
+ Misses        453      452       -1     
+ Partials      162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dionhaefner dionhaefner changed the title fix: allow using other base images than Debian fix: ensure using other base images than Debian works Apr 2, 2025
@dionhaefner dionhaefner changed the title fix: ensure using other base images than Debian works fix: ensure Ubuntu-based base images work as expected; change default to vanilla Debian Apr 3, 2025
@jpbrodrick89
Copy link
Contributor

If you're open to using Jax in your cuda tesseract a good test would be whether jax.lax.linalg.tridiag_solve runs successfully. This will check you've install the cusparse library correctly. Happy to discuss further.

@dionhaefner
Copy link
Contributor Author

There's no GPU available on CI so any code that actually uses CUDA will fail. I think for now a simple check whether the library is present will have to do.

@dionhaefner dionhaefner marked this pull request as ready for review April 7, 2025 07:35
@dionhaefner
Copy link
Contributor Author

Any takers for review? @xalelax @apaleyes

Copy link
Contributor

@xalelax xalelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionhaefner dionhaefner merged commit ceb6deb into main Apr 7, 2025
31 checks passed
@dionhaefner dionhaefner deleted the dion/base-images branch April 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure compatibility with other base images
4 participants