Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable users to opt-in to allowing extra fields in Tesseract schemas by setting extra="allow" #117

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

nmheim
Copy link
Contributor

@nmheim nmheim commented Apr 4, 2025

Relevant issue or PR

Pydantic models inside e.g. InputSchema that have extra="allow" failed with extra fields.

Description of changes

Only override with extra="forbid" if no model_config is given.

Testing done

Added a test.

License

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I sign the Developer Certificate of Origin below by adding my name and email address to the Signed-off-by line.
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: [Niklas Heim] <[[email protected]]>

@nmheim nmheim marked this pull request as draft April 4, 2025 11:39
@nmheim
Copy link
Contributor Author

nmheim commented Apr 4, 2025

Still have to write a test for this.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (ceb6deb) to head (434535c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   76.47%   76.49%   +0.01%     
==========================================
  Files          26       26              
  Lines        2606     2608       +2     
  Branches      390      390              
==========================================
+ Hits         1993     1995       +2     
  Misses        452      452              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dionhaefner
Copy link
Contributor

@nmheim Contribution looks good, let's get that tested asap?

@nmheim nmheim changed the title Don't override model_config inapply_function_to_model_tree if it exists refactor: Don't override model_config inapply_function_to_model_tree if it exists Apr 7, 2025
@nmheim nmheim changed the title refactor: Don't override model_config inapply_function_to_model_tree if it exists fix: Don't override model_config inapply_function_to_model_tree if it exists Apr 7, 2025
@nmheim nmheim marked this pull request as ready for review April 7, 2025 13:12
Copy link
Contributor

@dionhaefner dionhaefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dionhaefner dionhaefner changed the title fix: Don't override model_config inapply_function_to_model_tree if it exists fix: Allow users to opt-in to allowing extra fields in Tesseract schemas by setting extra="allow" Apr 8, 2025
@dionhaefner dionhaefner changed the title fix: Allow users to opt-in to allowing extra fields in Tesseract schemas by setting extra="allow" fix: Enable users to opt-in to allowing extra fields in Tesseract schemas by setting extra="allow" Apr 8, 2025
@dionhaefner dionhaefner merged commit fd5fc46 into main Apr 8, 2025
31 checks passed
@dionhaefner dionhaefner deleted the nh/model-config-override branch April 8, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants