-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable users to opt-in to allowing extra fields in Tesseract schemas by setting extra="allow"
#117
Conversation
Still have to write a test for this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 76.47% 76.49% +0.01%
==========================================
Files 26 26
Lines 2606 2608 +2
Branches 390 390
==========================================
+ Hits 1993 1995 +2
Misses 452 452
Partials 161 161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@nmheim Contribution looks good, let's get that tested asap? |
apply_function_to_model_tree
if it existsapply_function_to_model_tree
if it exists
apply_function_to_model_tree
if it existsapply_function_to_model_tree
if it exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
apply_function_to_model_tree
if it existsextra="allow"
extra="allow"
extra="allow"
Relevant issue or PR
Pydantic models inside e.g.
InputSchema
that haveextra="allow"
failed with extra fields.Description of changes
Only override with
extra="forbid"
if nomodel_config
is given.Testing done
Added a test.
License
Signed-off-by
line.Developer Certificate of Origin
Signed-off-by: [Niklas Heim] <[[email protected]]>