fix: use mlflow env variables directly for mlflow auth #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
Description of changes
In #416, we added support for mlflow auth. Originally, we used tesseract config variables and added it to the url via basic auth. However, mlflow directly outputs the url it receives, which results in leaking this information:
This goes back to the original approach of just using the
MLFLOW_USERNAME/MLFLOW_PASSWORDenv vars directly. The mlflow client reads them in, and we just have to read them from the env variable for the reachability check.Testing done
Local testing