Correct numerical errors in roundedFrameSection calculation #1355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I have a calendar view that scrolls horizontaly one month at a time:
When calling
calendar.scrollToDate()
, the calendar was scrolling to the wrong month anytime the specified date was a Sunday. Specifically, it was scrolling to the next previous month.The problem is due to the formula
floor(frameSection)
intargetPointForItemAt()
. Naturally,frameSection
may have small numerical errors. For example, a Sunday may yieldframeSection == 49.9999999999999
. However,floor(49.9999999999999) == 49
when the correct calculation should be 50.One potential fix, which is the one I'm submitting in this PR, is to reduce the numerical precision of
frameSection
from double to single before callingfloor()
. This correctly results infloor(50) == 50
.