handle empty optgroups #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes phoenixframework/phoenix_live_view#3742. When a select contained an empty optgroup <select> <optgroup label="optgroupabove"> <option selected value="1">a</option> <option value="2">b</option> <option value="3">c</option> </optgroup> <optgroup label="optgroupempty"></optgroup> <optgroup label="optgroupbelow"> <option value="4">d</option> <option value="5">e</option> <option value="6">f</option> </optgroup> </select> morphdom would stop when encountering the empty optgroup, not patching the nodes below. This is fixed by skipping to the next sibling when an optgroup does not have any children.
Contributor
Author
|
CI fixed in #269. |
Collaborator
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phoenixframework/phoenix_live_view#3742.
When a select contained an empty optgroup
morphdom would stop when encountering the empty optgroup, not patching the nodes below. This is fixed by skipping to the next sibling when an optgroup does not have any children.