Fix time calculation bug in sharing feature

[parzel]

Issue

There was an issue on how seconds and time.Seconds were cast when creating shared links, leading to them being immediately expired.

Description

I modified the casts to work properly.

[patrickhener]

Can you tell me how exactly you tested. Because if I use for example:

goshs -b test:test

in a folder, then share a file

this will make that file accessible for 60 minutes as desired. It is not expired right away.

[patrickhener]

But as your example works as well as mine and the code looks cleaner, I'll merge your variant. Thanks for contributing.

[parzel]

That is strange! I just verified it again and run into the same issue on the previous branch. Maybe there has been a change in go? I am running go1.24.4.

[patrickhener]

I am on 1.24.2

[parzel]

I think I was able to single out the issue. It only exists on my side when using the x86 version. Maybe you tested with x64?

[patrickhener]

Yes I tested x64. But the PR does resolve it on x86?

[parzel]

Ah I suppose got it. I think its an integer overflow because int(time.Second)* seconds can overflow the integer range. If you try to compile something like fmt.Printf("value: %v\n", time.Duration(int(time.Second)*3600)) you will get an overflow error from the compiler. As the second value is not known to it in the case of your program, it does not complain. The fix therefore helps on x86.