Skip to content

feat(CC-batch-1): added batch 1 #11827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(CC-batch-1): added batch 1 #11827

wants to merge 10 commits into from

Conversation

mattnolting
Copy link
Contributor

@mattnolting mattnolting commented May 13, 2025 •
edited
Loading

Relates to: #11624

Included components:

  • About Modal - requires followup discussion
  • Accordion
  • Action Llist
  • Background Image
  • Clipboard Copy

Component tracker

Figma preview

Resources:

@patternfly-build
Copy link
Contributor

patternfly-build commented May 13, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11827.surge.sh

A11y report: https://patternfly-react-pr-11827-a11y.surge.sh

@mattnolting mattnolting changed the title feat(CC-batch-1): prepared batch 1 feat(CC-batch-1): added batch 1 May 13, 2025
@mattnolting mattnolting force-pushed the feat-CC-batch-1 branch 2 times, most recently from dbf3c61 to 9f6488f Compare May 22, 2025 15:03
@mattnolting mattnolting marked this pull request as ready for review May 22, 2025 15:04
nicolethoen
nicolethoen requested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would each component benefit from an added comment linking directly to the component docs on patternfly.org? I think that'd be helpful.

@evwilkin evwilkin mentioned this pull request Jun 2, 2025
Open
3 tasks
nicolethoen

This comment was marked as resolved.

Sign in to view

nicolethoen
nicolethoen reviewed Jun 11, 2025
View reviewed changes
@mattnolting mattnolting marked this pull request as draft June 17, 2025 14:52
@mattnolting mattnolting marked this pull request as ready for review June 24, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evwilkin evwilkin evwilkin left review comments

@nicolethoen nicolethoen nicolethoen approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattnolting @patternfly-build @evwilkin @nicolethoen @kmcfaul