fix(Message): Truncate very long names #298
Conversation
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
| @@ -61,6 +61,13 @@ export default MessageLoading; | |||
| <Message name="Bot" role="bot" avatar={patternflyAvatar} content={orderedList} /> | |||
There was a problem hiding this comment.
Maybe we can change "Example content with updated timestamp text" from the first bot message to be "Text-based message from a bot named "Bot", with updated timestamp"? Maybe sounds a little weird, but it could be good to point out that there's already a name with these messages, I tbh didn't notice myself in previous prs.
Longer term, I wonder if we could rename it to "FlyBot" or something, just to make it more "real" and obvious. Just a side comment/low priority thing
There was a problem hiding this comment.
I just pushed these changes. We did have this issue come up: #299. I think we do need improved docs around timestamps. I added a line about it, but let me know if you envision something else. I figure we can update the Message docs here as part of that, but I'll update our demo examples to include timestamps separately before I close #299.
Our API has name as optional - I'm letting it render as optional and then also adding truncation if it gets really long. We prioritize the timestamp at full width over the name right now - let me know if we want to prioritize the name over the timestamp instead.