Skip to content

Commit

Permalink
[benchmark] Add a scalable_limited benchmark category.
Browse files Browse the repository at this point in the history
The following benchmark hangs on 8-core machines, but passes on 30-core
machines:

```
cpp-protobuf-async-client-unary-1channel-64wide-128breq-8mbresp-insecure
```

This PR creates a `scalable_limited` category in addition to the
`scalable` category typically run in CI, and aoplies it to all
`scalable` benchmarks except the one that fails on 8-core machines.

This change also changes the set of benchmarks run on 8-core machines to
use the `scalable_limited` category. Benchmarks run on 30-core machines
remain unchanged.
  • Loading branch information
paulosjca committed Jul 17, 2024
1 parent 99313f4 commit 9f5158c
Show file tree
Hide file tree
Showing 4 changed files with 89 additions and 72 deletions.
6 changes: 3 additions & 3 deletions tools/internal_ci/linux/grpc_e2e_performance_gke.sh
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ buildConfigs() {
-a ci_gitCommit_java="${GRPC_JAVA_COMMIT}" \
-a ci_gitActualCommit="${KOKORO_GIT_COMMIT}" \
--prefix="${LOAD_TEST_PREFIX}" -u "${UNIQUE_IDENTIFIER}" -u "${pool}" \
-a pool="${pool}" --category=scalable \
-a pool="${pool}" \
--allow_client_language=c++ --allow_server_language=c++ \
--allow_server_language=node \
-o "loadtest_with_prebuilt_workers_${pool}.yaml"
Expand All @@ -139,8 +139,8 @@ for language in "${disabledLanguages[@]}"; do
done

# Add arguments for languages.
declare -a configLangArgs8core=()
declare -a configLangArgs32core=()
declare -a configLangArgs8core=("--category=scalable_limited")
declare -a configLangArgs32core=("--category=scalable")
declare -a runnerLangArgs=()

# c++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ buildConfigs() {
-a ci_gitCommit_java="${GRPC_JAVA_COMMIT}" \
-a ci_gitActualCommit="${KOKORO_GIT_COMMIT}" \
--prefix="${LOAD_TEST_PREFIX}" -u "${UNIQUE_IDENTIFIER}" -u "${pool}" \
-a pool="${pool}" --category=scalable \
-a pool="${pool}" \
--allow_client_language=c++ --allow_server_language=c++ \
--allow_server_language=node \
-o "loadtest_with_prebuilt_workers_${pool}.yaml"
Expand All @@ -134,8 +134,8 @@ for language in "${disabledLanguages[@]}"; do
done

# Add arguments for languages.
declare -a configLangArgs8core=()
declare -a configLangArgs32core=()
declare -a configLangArgs8core=("--category=scalable_limited")
declare -a configLangArgs32core=("--category=scalable")
declare -a runnerLangArgs=()

# c++
Expand Down
Loading

0 comments on commit 9f5158c

Please sign in to comment.