Skip to content

[fix]: address compiler errors raised when building with Alpine/musl #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

robomics
Copy link
Contributor

No description provided.

@robomics robomics added the bug Something isn't working label Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (a7e95bd) to head (68d4cdb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../filestream/include/hictk/impl/filestream_impl.hpp 72.72% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   77.56%   77.55%   -0.01%     
==========================================
  Files         181      181              
  Lines       23630    23640      +10     
  Branches     2612     2612              
==========================================
+ Hits        18328    18335       +7     
- Misses       4152     4153       +1     
- Partials     1150     1152       +2     
Flag Coverage Δ
[tests fuzzer](https://app.codecov.io/gh/paulsengroup/hictk/pull/430/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 28.53% <0.00%> (-0.04%)
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/430/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.62% <8.33%> (-0.02%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/430/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 76.61% <75.00%> (-0.02%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robomics robomics merged commit 825dd65 into main Jul 15, 2025
89 of 90 checks passed
@robomics robomics deleted the fix/alpine branch July 15, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant