Multiple network resource and data source improvements #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paultyng @joshuaspence Is this repo still being maintained? |
|
This looks okay at a quick glance but I'd like to have acceptance test coverage before merging |
DevOpsFu
force-pushed
the
NetworkImprovements
branch
from
4b0645d to
618a20d
Compare
|
@joshuaspence I've added acceptance tests for the additional functionality. I'm not sure if they will pass or not - I was having trouble getting the tests to run locally (this is an issue with my setup rather than the tests themselves). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things with the Network resource and data source:
ipv6_ra_enabledoption name (it was previouslyipv6_ra_enablewhich does not match the JSON field name returned by the API.cidrZeroBasedon the IP Subnet. The subnet field is also used to specify the IP address which is allocated to the USG itself, and this was always being normalized to zero.nonethen the IPV6 settings are ignored. This removes the need to specify unused IPV6 settings to prevent unstable plans.