DEV: Remove Handlebars dependency #299
Open
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raw-handlebars will be removed from Discourse core imminently (discourse/discourse#32081) The usage in `custom-user-selector` seemed like it was expecting SafeString to actually do something to escape user input. It doesn't actually do any processing to the string. So I removed it, and added `escapeExpression` around the user input instead. The usage in wizard-char-counter can be easily replaced with Ember's `htmlSafe` helper
davidtaylorhq
force-pushed
the
remove-handlebars
branch
from
8a8f945 to
6b8db71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raw-handlebars will be removed from Discourse core imminently (discourse/discourse#32081)
The usage in
custom-user-selectorseemed like it was expecting SafeString to actually do something to escape user input. It doesn't actually do any processing to the string. So I removed it, and addedescapeExpressionaround the user input instead.The usage in wizard-char-counter can be easily replaced with Ember's
htmlSafehelper