perf(storage-s3): avoid getObject call if ETag matches#15295
Open
andershermansen wants to merge 4 commits intopayloadcms:mainfrom
Open
perf(storage-s3): avoid getObject call if ETag matches#15295andershermansen wants to merge 4 commits intopayloadcms:mainfrom
andershermansen wants to merge 4 commits intopayloadcms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Avoid unnecessary getObject call to S3 when the ETag matches.
Why?
Range support introduced an early headObject call, which already returns ETag and metadata; we can use that to short‑circuit with 304 and save a fetch.
How?
By using response headers from headObject and check ETag matching before invoking getObject.
Added a test case for verifying 200 status when If-None-Match does not match, and 304 status with empty body when If-None-Match is included and matching.