Update/powered by redesign #2499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikrom17
reviewed
May 21, 2025
…Styles is true. Only 'en' language updated so far
nikrom17
reviewed
Jun 3, 2025
| |}; | ||
|
|
||
| function getPoweredByConfig(): {| |
There was a problem hiding this comment.
We should have unit tests for this function
There was a problem hiding this comment.
Let's add some Karma tests for this.
Let's test:
- Rendering of legacy vs rebranded styles
- correct color based on button color
nikrom17
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated 'Powered by PayPal' message that appears at the bottom of the smart stack with the new design including the new PayPal logo.
The new design will only render if the paypal button is the rebranded experience as well. The REBRAND_BLUE and REBRAND_BLACK will render the black Powered By message, and REBRAND_WHITE will render the white Powered By message.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Ticket: https://paypal.atlassian.net/browse/DTPPCPSDK-2988
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!