Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console_engine and crossterm update #126

Merged
merged 1 commit into from
Apr 9, 2023
Merged

console_engine and crossterm update #126

merged 1 commit into from
Apr 9, 2023

Conversation

lesleyrs
Copy link
Contributor

@lesleyrs lesleyrs commented Apr 8, 2023

Small update that supports key release events on windows. I was hoping to make use of the new release event to have smooth movement. I added an example to console_engine that I wanted to port here but couldn't get the movement to change. It wasn't flawless anyway so I'll leave it as just a version bump.

I was also hoping it'd fix the map glitch on startup but it didn't, not sure what causes that still.

This is the example if you want to see it: https://github.com/VincentFoulon80/console_engine/blob/master/examples/scroll-smooth.rs

@lesleyrs
Copy link
Contributor Author

lesleyrs commented Apr 8, 2023

Closing this because it's being reverted crossterm-rs/crossterm#778

@lesleyrs lesleyrs closed this Apr 8, 2023
@TimonPost
Copy link

The press event should always be sent even when not having the new event-kind feature flag. So this could be a good change anyways. Just to be more precise.

@lesleyrs lesleyrs reopened this Apr 8, 2023
@pbellchambers pbellchambers merged commit 384aba1 into pbellchambers:main Apr 9, 2023
@pbellchambers
Copy link
Owner

Thanks for the PR!

@pbellchambers pbellchambers added the dependencies Pull requests that update a dependency file label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants