console_engine and crossterm update#126
Merged
pbellchambers merged 1 commit intopbellchambers:mainfrom Apr 9, 2023
lesleyrs:update
Merged
console_engine and crossterm update#126pbellchambers merged 1 commit intopbellchambers:mainfrom lesleyrs:update
pbellchambers merged 1 commit intopbellchambers:mainfrom
lesleyrs:update
Conversation
Contributor
Author
|
Closing this because it's being reverted crossterm-rs/crossterm#778 |
|
The press event should always be sent even when not having the new |
pbellchambers
approved these changes
Apr 9, 2023
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update that supports key release events on windows. I was hoping to make use of the new release event to have smooth movement. I added an example to console_engine that I wanted to port here but couldn't get the movement to change. It wasn't flawless anyway so I'll leave it as just a version bump.
I was also hoping it'd fix the map glitch on startup but it didn't, not sure what causes that still.
This is the example if you want to see it: https://github.com/VincentFoulon80/console_engine/blob/master/examples/scroll-smooth.rs