add upload photos context menu command #28
Conversation
| @@ -6,12 +6,19 @@ A Discord bot made for ACM Cyber & Psi Beta Rho. :) | |||
| 0. Install Node and make sure corepack is enabled (`corepack enable`). | |||
| 1. Download and copy `.env.example` as `.env` | |||
| 2. Run `pnpm install` to install dependencies | |||
| 3. Either ask me for your own discord bot user OR Create your own discord bot application: https://discordjs.guide/preparations/setting-up-a-bot-application.html | |||
| 4. [Invite your discord bot to our shared testing discord server](https://discordjs.guide/preparations/adding-your-bot-to-servers.html#creating-and-using-your-invite-link). If you need admin, let me (Alec) know. | |||
| 3. Either ask me (Alec or Andrew) for your own discord bot user OR Create your own discord bot application: https://discordjs.guide/preparations/setting-up-a-bot-application.html | |||
There was a problem hiding this comment.
We should probably avoid hard-coded names here - maybe like "the infrastructure lead?"
|
|
||
| let auth = await authorize() | ||
| const drive = google.drive({ version: "v3", auth }) | ||
| const folderId = "[FOLDER ID]" // replace this with the id of the desired folder (the part of the url after "folders/") |
There was a problem hiding this comment.
Ideally we should not hardcode config values - use an environment variable instead, which can be set in the .env file
|
|
||
| export const data = new ContextMenuCommandBuilder().setName("upload photos").setType(ApplicationCommandType.Message) | ||
|
|
||
| export async function execute(interaction) { |
There was a problem hiding this comment.
This seems a bit dangerous to allow anyone to run - I would recommend adding a check to only allow those with Administrator permission (basically the officers) as otherwise anyone could cause the bot to download arbitrary files into our disk and then into drive.
| await fs.promises.unlink(filePath) | ||
| count++ | ||
| } catch (error) { | ||
| console.error(`Failed to process file ${value["name"]}:`, error) |
There was a problem hiding this comment.
If an error occurs, we could be left with the file in our file system. I would recommend adding the fs.promises.unlink call inside of a finally clause.
| let auth = await authorize() | ||
| const drive = google.drive({ version: "v3", auth }) | ||
| const folderId = "[FOLDER ID]" // replace this with the id of the desired folder (the part of the url after "folders/") | ||
| const downloadDir = path.join(import.meta.dirname, "..", "downloads") |
There was a problem hiding this comment.
Since we don't want to save the files, we should probably save the files in a temporary directory, which can be created using tmpdir() + mkdtemp()
There was a problem hiding this comment.
Alternatively, you can look at streaming the data directly, which is probably the more ideal solution though it'll be a bit harder to get working - create a file read stream pointing to the remote attachment download url and stream it to Google Drive. Something like https://stackoverflow.com/questions/65976322/how-to-create-a-readable-stream-from-a-remote-url-in-nodejs would probably work - you might have to play around a bit.
| await fs.promises.unlink(filePath) | ||
| count++ | ||
| } catch (error) { | ||
| console.error(`Failed to process file ${value["name"]}:`, error) |
There was a problem hiding this comment.
Any chance we could send the list of files that failed to upload to the user?
This feature allows users to right click a Discord message, click an "upload photos" button, and upload the photo attachments of that message to a Google Drive folder (the folder should be shared with the service account's email and the folder id should be specified in uploadphotos.js).