Add optional Nova Scotia holidays #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the dates were returning as 23:00 for some reason (I think timezones), so I added an extra hour when I am coverting them in the relative date function, so that it finds the correct times.
This was recently brought to my attention. > I just wanted to flag an issue I noticed: as of this year, Manitoba celebrates Orange Shirt Day on September 30th (it's National Day for Truth and Reconciliation, but with a different name). > I noticed that day was missing from the Manitoba data on your tool, so just wanted to reach out and let you know. Correct! Updated.
Technically these are known as "Designated retail closing days", but they seem to serve the same function as optional holidays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few changes in this PR
Add optional NS holidays
I was asked to add in 'optional' holidays for NS, which seems to mean the "retail closing days" that are included on the NS website. Seems to be the same thing as optional holidays in other provinces, so let's ship them.
Change "Truth and Reconciliation Day" to "Orange Shirt Day" for Manitoba
Manitoba celebrates this holiday under a different name than the rest of Canada, and has also (since 2024) upgraded the status of this day to a legislated holiday, not an optional one.
Sometimes, when a holiday was on Saturday, it would say the observed date was on the Sunday, but this never happens. It's always on the next Monday. Due to what I am pretty sure was a timezone problem, some dates were being created as the 23:00 of the day before (eg, September 30 would be "12-29T23:00:00"). Since we don't care about the hours particularly, only the day, I figured an easy fix was to just add 1 hour to all dates to account for this weirdness.