-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Puerto Rico #34
Add Puerto Rico #34
Conversation
Likely need to adjust Bounding Pox for Puerto Rico
I think I may also need to add Puerto Rico data to the "us_states_raw.csv" file so the following works in format_map_df.R
the same goes for the centroid raw data (us_state_centroids_raw.csv) However, I'm not sure the source of those files. Any ideas? |
Here's something that may work to get shape data for PR:
|
I've now got something that mostly works, but needs a good bit of clean-up. The below map is created by the below code:
And just for reference, here's where San Juan is according to Google Maps: San Juan plots on the top right of the island in both images. There are a few things to revise, but here's one to start with: Create-map-df.R now just produces the needed extra data for PR, which is then merged to the older data in format-map-df.R. That process could probably be done all in create-map-df.R and format-map-df.R could be returned to its prior state. |
@dcaud Sorry for the delay in getting to this, I'll be reviewing the PR over the next couple days as I have time. Thanks for all your work! |
@sarah-colq Travis CI was removed after this PR was created, as well as a lot of other changes so the master branch would have to be merged into this PR first before continuing to work on it so that build issues could be resolved. |
Hi all! @pdil -- just following up on the status of this as Puerto Rico is still not visible (at least not in the CRAN version of the package). Great package and really looking forward to the Puerto Rico inclusion! Thanks! |
@erstearns Thanks for the kind words! Unfortunately this pull request is quite old, but I will look into adding Puerto Rico (and other territories) to the current package since there has been interest in its inclusion for some time. Issue #20 is still open so we can use that to track it. |
I've tried to revise things to make PR remapping in the Gulf of Mexico a reality.
I made some progress for sure:
Please have mercy on me...I'm still figuring out much of github, making changes to libraries, and your wonderful package!
Any idea what to do next?