Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default github_token to github.token #624

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link

@MichaelDeBoey MichaelDeBoey commented Jun 18, 2021

Fixes #309

@peaceiris
Copy link
Owner

Thank you for the work. This pull-request fixes #309

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #624 (4509111) into main (2c9f853) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files           4        4           
  Lines         277      277           
  Branches       49       49           
=======================================
  Hits          171      171           
  Misses        105      105           
  Partials        1        1           
Impacted Files Coverage Δ
src/set-tokens.ts 43.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9f853...4509111. Read the comment docs.

@MichaelDeBoey
Copy link
Author

@peaceiris I think this one can be merged?

@peaceiris
Copy link
Owner

I have added #309 to the v4 milestone. Since it takes a long time to publish, I will investigate this first from the viewpoint of backward compatibility, then try to merge this into the v3 line. 👍

@MichaelDeBoey
Copy link
Author

@peaceiris this PR is backwards compatible, as the action now defaults to github.token when it's not provided.
If people provide it themselves, it will still work.

@peaceiris
Copy link
Owner

peaceiris commented Sep 9, 2021

this PR is backwards compatible, as the action now defaults to github.token when it's not provided. If people provide it themselves, it will still work.

Not enough. We need to consider the source code. Perhaps, 631dd15 enables backward compatibility.

@peaceiris peaceiris marked this pull request as draft September 9, 2021 15:34
@privatenumber
Copy link

I understand this change is not backwards compatible because of the case where users are using personal_token instead of github_token (so this is empty).

AFAIK, using a PAT or GITHUB_TOKEN is interchangeable (just different permissions).

Would it be possible to eventually consolidate these two inputs into a token that defaults to github.token?

@peaceiris peaceiris added this to the v3.9.0 milestone Dec 21, 2021
@georgettica
Copy link

Could we promote this?
I saw some code and the GitHub token sws non required.
Would be glad to help here if I can (as it seems straightforward)

foursixnine added a commit to os-autoinst/os-autoinst-distri-opensuse that referenced this pull request Jul 21, 2022
Permission was wrong in the first place, waiting for peaceiris/actions-gh-pages#624 to be merged to update the version of the action.
ilmanzo pushed a commit to ilmanzo/os-autoinst-distri-opensuse that referenced this pull request Jul 25, 2022
Permission was wrong in the first place, waiting for peaceiris/actions-gh-pages#624 to be merged to update the version of the action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: default the github_token input to ${{ github.token }}
4 participants