Add expiration and message retention options to Subscription #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! In Cloud Pubsub we can specify for how long a message will be retained (https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create#request-body) We're using these changes on our production system and has been working pretty well. Our use case: We create many dynamic subscriptions during the day. Old subscriptions aren't used, so it ended up with some leftover long-lived subscriptions that we don't use. It can be dangerous because we have a limit on how many subscriptions we can have. The default expiration of an inactive subscription is 31 days, we want to reduce it to t the minimum value that is 1 day. However, according to the docs, the subscription expiration should always be greater than the message retention duration. The default message retention is 7 days, so we need to reduce it together.
Contributor
Author
|
Hi @peburrows, is everything alright with this PR? We found very valuable to fine tune how long a message can live in a GCP queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In Cloud Pubsub we can specify for how long a message will be retained (https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create#request-body)
We're using these changes on our production system and has been working pretty well.
Our use case:
We create many dynamic subscriptions during the day.
Old subscriptions aren't used, so it ended up with some leftover long-lived subscriptions that we don't use.
It can be dangerous because we have a limit on how many subscriptions we
can have. The default expiration of an inactive subscription is 31 days, we want to reduce it to t
the minimum value that is 1 day.
However, according to the docs, the subscription expiration should
always be greater than the message retention duration. The default
message retention is 7 days, so we need to reduce it together.