You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's no point in having clean_canonical_model, the canonical names will always be clean. It's almost surely not the case this doesn't do anything as most cameras don't have the issue in #19. But feel free to remove the camera you personally have as you can test it. It's to do the mass delete that I want to have the regression testing in place.
Do you need both for some reason? I'd use clean_model of the parent camera as canonical_model of itself and all aliases. If the point is to have one way to index into a specific camera having two versions of a "canonical" name sounds very strange. And using the clean one is best as cameras often have wonky names and the clean ones unify a lot of stuff so they're nicer if you want to automatically match something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20 but doesn't do anything until #19 is fixed as the rebel definitions simply overwrite the canonical_model values