[UPDATE] Add Socketio support #1292
Open
+529
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Greetings let me know how to properly contribute and run the unit tests |
WofWca
reviewed
Jul 30, 2024
| @@ -62,13 +64,45 @@ export abstract class DataConnection extends BaseConnection< | |||
| ); | |||
| } | |||
|
|
|||
| protected parseMaximumSize(description?: RTCSessionDescription): number { | |||
There was a problem hiding this comment.
Suggested change
| protected parseMaximumSize(description?: RTCSessionDescription): number { | |
| static parseMaximumSize(description?: RTCSessionDescription): number { |
Comment on lines
+120
to
+126
| "context": "browser", | ||
| "includeNodeModules": true, | ||
| "outputFormat": "esmodule", | ||
| "distDir": "./dist", | ||
| "publicUrl": "./", | ||
| "isLibrary": false, | ||
| "sourceMap": true |
There was a problem hiding this comment.
These are unrelated, right?
There was a problem hiding this comment.
There was no instructions of CONTRIBUTING.md, I did not know how to run the setup on my local machine and kept getting errors. Can you create a contributing.md guide for local setup? I also see the CI workflows but there is no information on how to sucessfully pass those either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.