Adding a project for the Las Vegas Metro area #351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
I needed a Pelias instance for the Las Vegas Metro/Clark County, Nevada area, so I added this.
Here's what actually got changed 👏
Copied
projects/portland-metro
and adapted it to Las Vegas Metro. This of course involved changes topelias.json
. I deleted theblacklist
directory and made the files undersynonyms
a little more vanilla (I may change add it more but to be honest I don't fully understand how the synonyms help, since test cases 37-40 insearch_address.json
are designed to fail). I also added some test cases, although not as many as withportland-metro
.EDIT: I realize that some resources are more locally specific while others are more Nevada specific. Please let me know if you think it would be a better idea to make this a project for Nevada as a whole. I also took the liberty to fix the spelling in other projects'
custom_street.txt
files ("fourth" was previously spelled as "forth")Here's how others can test the changes 👀
Run
pelias test run
. Feedback on the quality of my tests may not be necessary, but they would be appreciated.