Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate activity log event with properties #897

Open
Boy132 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #907
Open

Translate activity log event with properties #897

Boy132 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #907
Assignees
Labels
🐛 bug Something isn't working 🟡 medium Somewhat challenging

Comments

@Boy132
Copy link
Member

Boy132 commented Jan 9, 2025

Currently the activity log event is translated without properties, so placeholders aren't replaced.
Example, :file is not being replaced:
grafik

https://github.com/pelican-dev/panel/blob/main/app/Filament/Server/Resources/ActivityResource/Pages/ListActivities.php#L23

Old client area code: https://github.com/pelican-dev/panel/blob/release/v1.0.0-beta17/resources/scripts/components/elements/activity/ActivityLogEntry.tsx#L20-L39

@Boy132 Boy132 added 🐛 bug Something isn't working 🟡 medium Somewhat challenging labels Jan 9, 2025
@Boy132 Boy132 self-assigned this Jan 13, 2025
@Boy132 Boy132 linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🟡 medium Somewhat challenging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant