Skip to content

Fix translations for activity logs#907

Merged
Boy132 merged 7 commits intomainfrom
boy132/activity-log-properties
Jan 23, 2025
Merged

Fix translations for activity logs#907
Boy132 merged 7 commits intomainfrom
boy132/activity-log-properties

Conversation

@Boy132
Copy link
Member

@Boy132 Boy132 commented Jan 13, 2025

Closes #897

Needs pelican-dev/wings#59 in order for sftp file events to work.

@Boy132 Boy132 self-assigned this Jan 13, 2025
@Boy132 Boy132 marked this pull request as ready for review January 13, 2025 10:55
Copy link
Member

@rmartinoscar rmartinoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Try deleting a file using the recyclebin on the right, it works for bulkaction but not the single one

image

Try renaming a file within a dir

Man idk what's wrong with my gh it keeps Approving & clear my comment when i request changes

Running on wings canary with Quinten

    metadata := make(map[string]interface{})

    // Check if the target is empty
    if fa.Target == "" {
        // Only include the "files" key when no target is provided
        metadata["files"] = []string{fa.Entity}
    } else {
        // Include "from" and "to" fields when a target exists
        metadata["from"] = fa.Entity
        metadata["to"] = fa.Target
    }

@Boy132 Boy132 requested a review from rmartinoscar January 15, 2025 17:32
@Boy132 Boy132 merged commit 37ba624 into main Jan 23, 2025
17 checks passed
@Boy132 Boy132 deleted the boy132/activity-log-properties branch January 23, 2025 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate activity log event with properties

3 participants