Skip to content

chore: Refactor Mounts #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Refactor Mounts #1236

wants to merge 1 commit into from

Conversation

rmartinoscar
Copy link
Contributor

@rmartinoscar rmartinoscar commented Apr 11, 2025 •
edited
Loading

Move mount_node, server_mount & egg_mount into a single model_has_mounts table

@rmartinoscar rmartinoscar self-assigned this Apr 11, 2025
lancepioch
lancepioch previously approved these changes Apr 12, 2025
View reviewed changes
@rmartinoscar rmartinoscar force-pushed the chore/MountNodePivot branch from 46affe2 to e94a682 Compare April 12, 2025 11:14
@rmartinoscar rmartinoscar marked this pull request as draft April 12, 2025 12:50
@rmartinoscar rmartinoscar force-pushed the chore/MountNodePivot branch from e94a682 to 3b5db45 Compare April 12, 2025 22:21
@rmartinoscar rmartinoscar marked this pull request as ready for review April 12, 2025 22:24
@rmartinoscar rmartinoscar requested a review from lancepioch April 12, 2025 22:25
@rmartinoscar rmartinoscar changed the title chore: Use Pivot instead of Model for MountNode chore: Refactor Mounts Apr 12, 2025
@rmartinoscar rmartinoscar marked this pull request as draft April 12, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notAreYouScared notAreYouScared Awaiting requested review from notAreYouScared

@Boy132 Boy132 Awaiting requested review from Boy132

@alexevladgabriel alexevladgabriel Awaiting requested review from alexevladgabriel

@lancepioch lancepioch Awaiting requested review from lancepioch

At least 1 approving review is required to merge this pull request.

Assignees

@rmartinoscar rmartinoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartinoscar @lancepioch