Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
…art-one # Conflicts: # app/Filament/Admin/Resources/ApiKeyResource/Pages/CreateApiKey.php # app/Filament/Admin/Resources/ApiKeyResource/Pages/ListApiKeys.php # app/Filament/Admin/Resources/DatabaseHostResource.php # app/Filament/Admin/Resources/DatabaseHostResource/Pages/CreateDatabaseHost.php # app/Filament/Admin/Resources/DatabaseHostResource/Pages/EditDatabaseHost.php # app/Filament/Admin/Resources/DatabaseHostResource/Pages/ListDatabaseHosts.php # app/Filament/Admin/Resources/MountResource.php # app/Filament/Admin/Resources/MountResource/Pages/CreateMount.php # app/Filament/Admin/Resources/MountResource/Pages/EditMount.php # app/Filament/Admin/Resources/MountResource/Pages/ListMounts.php # app/Filament/Admin/Resources/RoleResource/Pages/EditRole.php # app/Filament/Admin/Resources/RoleResource/Pages/ListRoles.php # app/Filament/Admin/Resources/UserResource/Pages/CreateUser.php # app/Filament/Admin/Resources/UserResource/Pages/EditUser.php # app/Filament/Admin/Resources/UserResource/Pages/ListUsers.php # app/Filament/Admin/Resources/WebhookResource.php # app/Filament/Admin/Resources/WebhookResource/Pages/CreateWebhookConfiguration.php # app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php # app/Filament/Admin/Resources/WebhookResource/Pages/ListWebhookConfigurations.php
…art-one # Conflicts: # app/Filament/Admin/Resources/WebhookResource/Pages/CreateWebhookConfiguration.php
…art-one # Conflicts: # app/Filament/Admin/Resources/ApiKeyResource/Pages/ListApiKeys.php # app/Filament/Admin/Resources/DatabaseHostResource/Pages/ListDatabaseHosts.php # app/Filament/Admin/Resources/MountResource/Pages/ListMounts.php # app/Filament/Admin/Resources/NodeResource/Pages/ListNodes.php # app/Filament/Admin/Resources/ServerResource/Pages/ListServers.php # app/Filament/Admin/Resources/WebhookResource/Pages/ListWebhookConfigurations.php
lancepioch
approved these changes
Feb 24, 2025
Member
lancepioch
left a comment
lancepioch
left a comment
There was a problem hiding this comment.
Code looks good, but before merging, let's discuss this in team chat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds view pages (#583) for the "simple" resources which means everything except Egg, Node and Server.
tableandformmethods were moved to the Resource class so the view pages can use a disabled form and to avoid duplicate code.+ the table for mounts got a little rework:
