Conversation
change go version for push and release to 1.25.7 and 1.26.0
📝 WalkthroughWalkthroughUpdated CI and build images to newer Go toolchain versions: push workflow matrix now uses Go 1.25.7 and 1.26.0 with artifact uploads gated only for 1.25.7; release workflow and Dockerfile builder stage updated to Go 1.25.7. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You forgot the dockerfile |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile (1)
2-2: Pin the Go builder image by digest for reproducible builds.Line 2 currently uses a mutable tag (
golang:1.25.7-alpine). Consider pinning to a digest to prevent silent upstream image drift.Suggested change
-FROM golang:1.25.7-alpine AS builder +FROM golang:1.25.7-alpine@sha256:<resolved-digest> AS builder#!/bin/bash set -euo pipefail repo="library/golang" tag="1.25.7-alpine" token="$(curl -fsSL "https://auth.docker.io/token?service=registry.docker.io&scope=repository:${repo}:pull" \ | sed -n 's/.*"token":"\([^"]*\)".*/\1/p')" digest="$(curl -fsSI \ -H "Authorization: Bearer ${token}" \ -H "Accept: application/vnd.docker.distribution.manifest.v2+json" \ "https://registry-1.docker.io/v2/${repo}/manifests/${tag}" \ | tr -d '\r' | awk -F': ' '/Docker-Content-Digest/{print $2}')" if [ -z "${digest}" ]; then echo "Digest not found for ${repo}:${tag}" >&2 exit 1 fi echo "Resolved digest: ${digest}"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile` at line 2, The Dockerfile uses a mutable image tag in the FROM instruction ("FROM golang:1.25.7-alpine") which can cause unreproducible builds; update that FROM line to pin the Go builder image to its immutable digest (replace the tag with the resolved digest for the golang:1.25.7-alpine manifest) so builds are reproducible—locate the FROM line in the Dockerfile and swap "golang:1.25.7-alpine" for the corresponding "golang@sha256:..." digest obtained from the registry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Dockerfile`:
- Line 2: The Dockerfile uses a mutable image tag in the FROM instruction ("FROM
golang:1.25.7-alpine") which can cause unreproducible builds; update that FROM
line to pin the Go builder image to its immutable digest (replace the tag with
the resolved digest for the golang:1.25.7-alpine manifest) so builds are
reproducible—locate the FROM line in the Dockerfile and swap
"golang:1.25.7-alpine" for the corresponding "golang@sha256:..." digest obtained
from the registry.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (go)
- GitHub Check: Build and Test (ubuntu-22.04, 1.26.0, linux, amd64)
- GitHub Check: Build and Test (ubuntu-22.04, 1.25.7, linux, amd64)
change go version for push and release to 1.25.7 and 1.26.0
Summary by CodeRabbit