-
Notifications
You must be signed in to change notification settings - Fork 69
feat: add via proxy egg #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SteadEXE
wants to merge
6
commits into
pelican-eggs:main
Choose a base branch
from
SteadEXE:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintenQVD0
requested changes
May 30, 2025
QuintenQVD0
requested changes
May 30, 2025
Because I didn’t knew it existed 😅
Le ven. 30 mai 2025 à 10:50, Quinten ***@***.***> a écrit :
… ***@***.**** requested changes on this pull request.
------------------------------
In proxy/java/viaproxy/egg-via-proxy.json
<#79 (comment)>
:
> @@ -25,7 +25,7 @@
"scripts": {
"installation": {
"script": "#!\/bin\/ash\r\n# ViaProxy Installation Script\r\n#\r\n# Server Files: \/mnt\/server\r\ncd \/mnt\/server\r\n\r\n# Check if VIA_PROXY_VERSION is set\r\nif [ -z \"$VIA_PROXY_VERSION\" ]; then\r\n echo \"VIA_PROXY_VERSION environment variable is not set.\"\r\n exit 1\r\nfi\r\n\r\n# Fetch the latest version if VIA_PROXY_VERSION is \"latest\"\r\nif [ \"$VIA_PROXY_VERSION\" = \"latest\" ]; then\r\n echo \"Fetching the latest version...\"\r\n LATEST_RELEASE_URL=\"https:\/\/github.com\/ViaVersion\/ViaProxy\/releases\/latest\"\r\n RELEASE_INFO=$(curl -L -s -H \"Accept: application\/json\" \"$LATEST_RELEASE_URL\")\r\n\r\n # Extract the tag_name which contains the version\r\n VIA_PROXY_VERSION=$(echo \"$RELEASE_INFO\" | grep -o '\"tag_name\": *\"[^\"]*\"' | cut -d '\"' -f 4 | sed 's\/^v\/\/')\r\n\r\n if [ -z \"$VIA_PROXY_VERSION\" ]; then\r\n echo \"Failed to fetch the latest version.\"\r\n exit 1\r\n fi\r\nfi\r\n\r\n# Construct the download URL\r\nDOWNLOAD_URL=\"https:\/\/github.com\/ViaVersion\/ViaProxy\/releases\/download\/v${VIA_PROXY_VERSION}\/ViaProxy-${VIA_PROXY_VERSION}.jar\"\r\n\r\n# Download the .jar file\r\necho \"Downloading ViaProxy version $VIA_PROXY_VERSION...\"\r\ncurl -L -o \"$SERVER_JARFILE\" \"$DOWNLOAD_URL\"\r\n\r\nif [ $? -eq 0 ]; then\r\n echo \"Download complete. The file is saved as $SERVER_JARFILE.\"\r\nelse\r\n echo \"Failed to download the .jar file.\"\r\n exit 1\r\nfi",
Is there a reason you did it this way instead of our GitHub release grab
script?
https://github.com/pelican-eggs/eggs/blob/master/scripts/github_release_grabber.sh
—
Reply to this email directly, view it on GitHub
<#79 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANNPNFMN5LF2BX5NPCSDW33BALT3AVCNFSM6AAAAAB6HJZXR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOBQGYYTOMRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I added the pterodactyl export and added the missing features. Also, userinteraction does not exist anymore so I removed that |
QuintenQVD0
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to add ViaProxy standalone to be able to use it in combo with GeyserMC. Both documentations (Geyser and ViaProxy says it's the way to go).
I saw there is already VIAaaS but it seems a bit overkill for a simple usecase.
My egg is a fork of the GeyserMC's egg.
I slightly updated the VIAaaS description in the README to explain the differences between both egg
This is my first PR.
Checklist for all submissions
I didn't bothered creating a branch tbh
New egg Submissions