Skip to content

feat: add via proxy egg #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add via proxy egg #79

wants to merge 6 commits into from

Conversation

SteadEXE
Copy link

@SteadEXE SteadEXE commented May 30, 2025

Description

I wanted to add ViaProxy standalone to be able to use it in combo with GeyserMC. Both documentations (Geyser and ViaProxy says it's the way to go).
I saw there is already VIAaaS but it seems a bit overkill for a simple usecase.
My egg is a fork of the GeyserMC's egg.

I slightly updated the VIAaaS description in the README to explain the differences between both egg

This is my first PR.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

I didn't bothered creating a branch tbh

  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@SteadEXE SteadEXE marked this pull request as draft May 30, 2025 07:03
@SteadEXE SteadEXE marked this pull request as ready for review May 30, 2025 07:06
@SteadEXE
Copy link
Author

SteadEXE commented May 30, 2025 via email

@QuintenQVD0
Copy link
Contributor

QuintenQVD0 commented Jun 1, 2025

I added the pterodactyl export and added the missing features. Also, userinteraction does not exist anymore so I removed that

Copy link
Contributor

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants