feat: relocating metrics port for nidhogg manager to avoid conflicts

[scoquelin]

Tested with kustomize build .

OUTPUT :

...
apiVersion: apps/v1
kind: StatefulSet
metadata:
  labels:
    control-plane: controller-manager
    controller-tools.k8s.io: "1.0"
  name: nidhogg-controller-manager
  namespace: nidhogg-system
spec:
  replicas: 2
  selector:
    matchLabels:
      control-plane: controller-manager
      controller-tools.k8s.io: "1.0"
  serviceName: nidhogg-controller-manager-service
  template:
    metadata:
      labels:
        control-plane: controller-manager
        controller-tools.k8s.io: "1.0"
    spec:
      containers:
      - args:
        - --config-file=/config/config.json
        - --leader-election
        - --leader-namespace=nidhogg-system
        - --leader-configmap=nidhogg-election
        - --metrics-addr=8081
        command:
        - /manager
        env:
        - name: POD_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        - name: SECRET_NAME
          value: nidhogg-webhook-server-secret
        image: ghcr.io/pelotech/nidhogg:v0.5.1
        imagePullPolicy: Always
        name: manager
        ports:
        - containerPort: 9876
          name: webhook-server
          protocol: TCP
        - containerPort: 8081
          name: metrics
          protocol: TCP
...

Closes #98

[chomatdam]

Two questions:

• do we want to bump nidhogg to latest (0.5.3)?
• do we want to use our container image value here instead of applying it through a Kustomize image tag override here?

[scoquelin]

Two questions:

• do we want to bump nidhogg to latest (0.5.3)?

Yes I think we should, I just wanted a way to test it, let's discuss how we can do this

• do we want to use our container image value here instead of applying it through a Kustomize image tag override here?

Yes we should definitely use the "real" container image here. I will start by doing a cleanup PR in that area on the nidhogg side of things.

[chomatdam]

Owning Nidhogg, I would probably fix it in the Nidhogg repo itself

[josmo]

So this never got merged however I just opened #215 since I don't think nidhogg needs to be on the hostnetwork in the frist place. If we merge removing hostnetwork, we should be able to just close this out :)