Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mappings between various representation of languages #45

Closed
wants to merge 1 commit into from

Conversation

kostrahb
Copy link

@kostrahb kostrahb commented Aug 27, 2023

This basically adds possibility to find language based on ISO 639-1 and ISO 639-3 code strings. Implementation is not entirely optimal - it would be great to unite the code base only on single language enum and transform to/from ISO codes via maps, but this does not break API and gets the thing done.

@codecov-commenter
Copy link

Codecov Report

Merging #45 (bdc88b1) into main (cf22a07) will decrease coverage by 10.12%.
Report is 3 commits behind head on main.
The diff coverage is 36.36%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   86.79%   76.67%   -10.12%     
===========================================
  Files           8        9        +1     
  Lines        1598     1608       +10     
===========================================
- Hits         1387     1233      -154     
- Misses        156      320      +164     
  Partials       55       55               
Files Changed Coverage Δ
language.go 61.61% <ø> (-35.63%) ⬇️
mapping.go 36.36% <36.36%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pemistahl
Copy link
Owner

pemistahl commented Sep 5, 2023

Closed in favor of commit a8305a1.

@pemistahl pemistahl closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants