Skip to content

Conversation

@Casxt
Copy link

@Casxt Casxt commented Dec 12, 2023

Hi @pemistahl,
I'm happy to add a new language to this amazing project.
I've carefully followed the SOP for adding a new language, and everything looks good. However, I've noticed a slight change in the whatlang output, pls kindly check this if needed.

@pemistahl
Copy link
Owner

Thanks a lot for this PR. I will need some time to review it but I will get back to you as soon as I'm done with it.

@pemistahl
Copy link
Owner

@Casxt Some unit tests have failed. Can you fix them please?

@Casxt
Copy link
Author

Casxt commented Dec 25, 2023

@Casxt Some unit tests have failed. Can you fix them please?

Hi @pemistahl, ut should be fixed

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.43%. Comparing base (b30f17c) to head (d4286db).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
alphabet.go 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   87.48%   87.43%   -0.05%     
==========================================
  Files           8        8              
  Lines        1598     1608      +10     
==========================================
+ Hits         1398     1406       +8     
- Misses        147      149       +2     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants