Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fw] Init HSPI in sd_card.cpp, avoid use default pins. #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fw] Init HSPI in sd_card.cpp, avoid use default pins. #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 2.Firmware/HoloCubic-fw/src/sd_card.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ void SdCard::init()
{

SPIClass* sd_spi = new SPIClass(HSPI); // another SPI
sd_spi->begin(14, 26, 13, 15); // Replace default HSPI pins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefert add macro like #define SD_SCL XX on top of file.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's more, remove the related description about modifing library in README.md.

if (!SD.begin(15, *sd_spi)) // SD-Card SS pin is 15
{
Serial.println("Card Mount Failed");
Expand Down