multiple test fixes #306
Merged
multiple test fixes #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able 20000101000000 was copied from the ext tests. But that's not in seconds since the Epoch but YYYYMMDDHHMMSS. Change the value to the correct timestamp and update the dump files accordingly. This should also fix the test for architectures without support for 64-bit timestamps. Signed-off-by: Michael Olbrich <[email protected]>
By default, mkfs.erofs will use the page size as block size. This breaks the test for architectures with a different page size. Unfortunately, older versions of mkfs.erofs don't support setting the block size. So conditionally use a different config for newer versions. That way, the test will at least succeed with the new version. Signed-off-by: Michael Olbrich <[email protected]>
On some architectures (e.g. Aarch64), the compress rate is 'nan' instead of '-nan'. Normalize the output to 'nan' for all. Signed-off-by: Michael Olbrich <[email protected]>
By default, mkfs.cramfs will use the page size as block size. This breaks the test for architectures with a different page size. Add extraargs to the test config to enforce a 4k block size. Signed-off-by: Michael Olbrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for test failures on architectures other than x86_64. See #299 (comment)