Skip to content

[BACKLOG-41542] - more support for repository file operations #10030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BACKLOG-41542] - more support for repository file operations #10030

wants to merge 1 commit into from

Conversation

abryant-hv
Copy link
Contributor

  • allow Spoon.openFile to work on repository paths
  • use repository path instead of just filename when opening a repository file from recents.

@hitachivantarasonarqube HitachiVantaraSonarQube

This comment has been minimized.

Sign in to view
@buildguy

This comment has been minimized.

Sign in to view
@abryant-hv
[BACKLOG-41542] - more support for repository file operations
e3aeb46 
- allow Spoon.openFile to work on repository paths
- use repository path instead of just filename when opening a
  repository file from recents.
- send Save ExtensionPoint events after repository save
@hitachivantarasonarqube HitachiVantaraSonarQube
Copy link

Failed

  • B Maintainability Rating on New Code (is worse than A)
  • 4.30% Coverage on New Code (is less than 80.00%)
  • 2 New Issues (is greater than 0)

Analysis Details

2 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 2 Code Smells

Coverage and Duplications

  • Coverage 4.30% Coverage (5.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (24.40% Estimated after merge)

Project ID: org.pentaho.di:pdi

View in SonarQube

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@buildguy
Copy link
Collaborator

⚠️ Build finished in 31m 51s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl plugins/pur/core,ui

⛔ Failed Tests

⛈️ 1 test(s) failed:

org.pentaho.di.ui.trans.step.BaseStepDialog_ConnectionLine_Test.org.pentaho.di.ui.trans.step.BaseStepDialog_ConnectionLine_Test (click to expand)

No more handles [gtk_init_check() failed]

Tests run: 588, Failures: 1, Skipped: 0    Test Results

ℹ️ This is an automatic message

@abryant-hv abryant-hv marked this pull request as ready for review July 7, 2025 14:59
@abryant-hv abryant-hv requested a review from a team as a code owner July 7, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abryant-hv @buildguy