Skip to content

[BACKLOG-44225] Use repository move and rename calls #10042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

tgf
Copy link
Contributor

@tgf tgf commented Jul 1, 2025

No description provided.

@tgf tgf requested a review from a team as a code owner July 1, 2025 16:55

This comment has been minimized.

@buildguy

This comment has been minimized.

@tgf tgf force-pushed the blg-44225_moveRenameRepoVfs branch 2 times, most recently from ef16ecd to 95b3e9a Compare July 2, 2025 13:44

This comment has been minimized.

@tgf tgf force-pushed the blg-44225_moveRenameRepoVfs branch 5 times, most recently from 2e3c339 to 49af7a2 Compare July 2, 2025 14:35
@tgf tgf changed the title BACKLOG-44225] Use repository move and rename calls [BACKLOG-44225] Use repository move and rename calls Jul 2, 2025

This comment has been minimized.

@buildguy

This comment has been minimized.

This comment has been minimized.

@buildguy

This comment has been minimized.

@tgf tgf force-pushed the blg-44225_moveRenameRepoVfs branch from 49af7a2 to ddcee33 Compare July 3, 2025 09:55

This comment has been minimized.

@buildguy

This comment has been minimized.

@@ -18,4 +18,9 @@ URL.Path.ImportService=/api/repo/files/import/multiple

URL.Path.RetrieveContent=/api/repo/{0}/content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just curious. What is the advantage of storing these urls in config file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is one, as changes in endpoints will likely need changes in the code as well.
Basically libpensol did it like that and I kept the approach; by the time I started questioning it, it was more effort to change than to keep it.

@tgf tgf force-pushed the blg-44225_moveRenameRepoVfs branch from ddcee33 to eb9d6e1 Compare July 9, 2025 10:39
Copy link

Failed

  • 75.40% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 75.40% Coverage (59.40% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: org.pentaho.di:pdi

View in SonarQube

@buildguy
Copy link
Collaborator

buildguy commented Jul 9, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

buildguy commented Jul 9, 2025

✅ Build finished in 26m 5s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
plugins/repo-vfs/repo-vfs-core

👌 All tests passed!

Tests run: 13, Failures: 0, Skipped: 0    Test Results


ℹ️ This is an automatic message

@pdesai16 pdesai16 merged commit ad6f638 into pentaho:master Jul 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants