Allow downloading of ffmpeg/ffprobe if no acceptable executables on path #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I install ffmpeg even if the command isn't fully provided args to allow namer to leverage video hashes to install ffmpeg as well. |
This was referenced Dec 28, 2022
Author
|
This has shipped with namer for a while. All Amd64 oses are tested in namer's GitHub actions build. Arm64 likely been tested by someone by now, arm linux, couldn't say..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This downloads ffmpeg/ffprobe if no acceptable ffmpeg/ffprobe is on the path. By default the download is in the same dir as the executable, but may be overridden with the new command line flag.