Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVEREST-1899 Replace REST-based Kubernetes client with controller-runtime.Client #1173

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

EVEREST-1899 Replace REST-based Kubernetes client with controller-runtime.Client #1173

wants to merge 33 commits into from

Conversation

maxkondr
Copy link
Contributor

@maxkondr maxkondr commented Mar 7, 2025 •
edited
Loading

EVEREST-1899 Powered by Pull Request Badge

  1. Completely replace REST- based go-client with controller-runtime.Client for interactions with Kubernetes.
    1.2 37 files (mostly /pkg/kubernetes/client/*) have been removed as not needed anymore
  2. Mocked Kubernetes client has been replaced with controller-runtime fake client - it provides more flexibility and operates with K8S structs (i.e. everestv1alpha1.DatabaseCluster{}, corev1.Pod{}, etc)
  3. Cleaned up unused methods from KubernetesConnector interface.
  4. Caching functionality is completely disabled so far.
  5. Tests have been adjusted.

@maxkondr maxkondr self-assigned this Mar 7, 2025
@maxkondr maxkondr marked this pull request as ready for review March 15, 2025 15:33
@maxkondr maxkondr requested a review from a team as a code owner March 15, 2025 15:33
oksana-grishchenko
oksana-grishchenko reviewed Mar 17, 2025
View reviewed changes
mayankshah1607
mayankshah1607 reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@mayankshah1607 mayankshah1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a partial review, will continue a bit later. Meanwhile, just left some minor nits

recharte
recharte reviewed Mar 20, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oksana-grishchenko oksana-grishchenko oksana-grishchenko approved these changes

@recharte recharte recharte approved these changes

@mayankshah1607 mayankshah1607 mayankshah1607 approved these changes

Assignees

@maxkondr maxkondr

Labels
auto-update-base feature-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxkondr @recharte @mayankshah1607 @oksana-grishchenko @percona-robot